jzhuge commented on code in PR #4925: URL: https://github.com/apache/iceberg/pull/4925#discussion_r1015834172
########## api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import java.util.List; +import org.apache.iceberg.catalog.Namespace; + +public interface SQLViewRepresentation extends ViewRepresentation { + + @Override + default Type type() { + return Type.SQL; + } + + /** The view query SQL text. */ + String query(); + + /** The view query SQL dialect. */ + String dialect(); + + /** The default catalog when the view is created. */ + String defaultCatalog(); + + /** The default namespace when the view is created. */ + Namespace defaultNamespace(); + + /** + * The output column names of the query that creates this view. The field aliases are not applied. + */ + List<String> queryColumnNames(); Review Comment: It is tricky. See discussion in Spark PR https://github.com/apache/spark/pull/37556#discussion_r1014506227. Currently the Spark PR will pass the following fields to v2 view catalog similar to v1 view: - Post-alias schema - Query column names Of course Iceberg can choose to store pre-alias schema and compute post-alias schema and query column names on the fly: - during create, Iceberg can compute and store pre-alias schema based on post-alias schema and query column names. Iceberg will not store query column names - during usage, Iceberg can compute post-alias schema and query column names on the fly based on stored pre-alias schema and field alias What approach should we take? cc @xkrogin @wmoustafa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
