wmoustafa commented on code in PR #4925: URL: https://github.com/apache/iceberg/pull/4925#discussion_r1015680437
########## api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import java.util.List; +import org.apache.iceberg.catalog.Namespace; + +public interface SQLViewRepresentation extends ViewRepresentation { + + @Override + default Type type() { + return Type.SQL; + } + + /** The view query SQL text. */ + String query(); + + /** The view query SQL dialect. */ + String dialect(); Review Comment: I think it is fine to do either: not take a position at all or take a well defined position. There could be a few scenarios where the intended meaning is not achieved. For example: * One defines the view SQL using a non-SQL string (e.g., some other DSL), and still leverages `SQLViewReperesentation` for that. Even if this is permitted, it is not clear from the spec if it is okay. * The dialect could be the same but not standardized, e.g., dialects such as `spark`, `Spark`, `SparkSQL`, `Spark SQL`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
