Fokko commented on code in PR #6127:
URL: https://github.com/apache/iceberg/pull/6127#discussion_r1015499369
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -281,6 +289,30 @@ def __invert__(self) -> BoundIsNull:
return BoundIsNull(self.term)
+def coerce_unary_arguments(data_class: Union[type, None]) -> Union[type,
Callable[[type], type]]:
Review Comment:
I'm not sold on this, mostly because it adds another layer of complexity.
These things should normally just happen in the init. I've created a PR
https://github.com/apache/iceberg/pull/6139 That does exactly this, well tested
👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
