rdblue commented on PR #5150: URL: https://github.com/apache/iceberg/pull/5150#issuecomment-1304951287
> I am unsure of how to proceed for branches and tags usecase. Just making changes to read from branch/tag in SparkScanBuilder worked before for previous versions of spark - 3.1, 3.2. But for 3.3 , properties get overridden in SparkCatalog.java before reaching SparkScanBuilder.java The current implementation looks fine to me. If those code paths are taken, it indicates that Spark was passed syntax like `TIMESTAMP AS OF '...'`, which should be incompatible with `branch` or `tag` options. This PR already implements that because the snapshot passed to `SparkTable` is added to options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
