rdblue commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1014893653


##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -141,6 +142,8 @@ public CloseableIterable<FileScanTask> planFiles() {
           doPlanFiles(),
           () -> {
             planningDuration.stop();
+            Map<String, String> metadata = 
Maps.newHashMap(context().options());
+            metadata.putAll(EnvironmentContext.get());

Review Comment:
   How is it helpful? I see that metadata is generic, but I don't understand 
the value of mixing these together, versus having a separate context map and 
options map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to