fb913bf0de288ba84fe98f7a23d35edfdb22381 commented on code in PR #6110: URL: https://github.com/apache/iceberg/pull/6110#discussion_r1013619657
########## api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java: ########## @@ -65,10 +65,17 @@ public void testSpecValues() { Assert.assertEquals("Spec example: hash(true) = 1392991556", 1392991556, BucketUtil.hash(1)); Assert.assertEquals("Spec example: hash(34) = 2017239379", 2017239379, BucketUtil.hash(34)); Assert.assertEquals("Spec example: hash(34L) = 2017239379", 2017239379, BucketUtil.hash(34L)); + Assert.assertEquals( "Spec example: hash(17.11F) = -142385009", -142385009, BucketUtil.hash(1.0F)); Assert.assertEquals( "Spec example: hash(17.11D) = -142385009", -142385009, BucketUtil.hash(1.0D)); + Assert.assertEquals("Spec example: hash(0.0F) = 1669671676", 1669671676, BucketUtil.hash(0.0F)); + Assert.assertEquals( + "Spec example: hash(-0.0F) = 1669671676", 1669671676, BucketUtil.hash(-0.0F)); + Assert.assertEquals("Spec example: hash(0.0) = 1669671676", 1669671676, BucketUtil.hash(0.0)); + Assert.assertEquals("Spec example: hash(-0.0) = 1669671676", 1669671676, BucketUtil.hash(-0.0)); Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org