szehon-ho commented on PR #6045: URL: https://github.com/apache/iceberg/pull/6045#issuecomment-1297574296
Took a look with @haizhou-zhao , I think we can make the following changes with to make this patch more mergeable and address some of the review comments: - Split out changing user.name => UserGroupInformation, as there seems to be some questions - Only set the type if we are on Hive 3 (using MetastoreUtil for version-specific code) So then the change will only set owner, type on HiveDb for createNamespace, if the user passes it in via properties. Owner will take from user.name if that is not passed it. This will be in line with the table today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
