szehon-ho commented on code in PR #4577:
URL: https://github.com/apache/iceberg/pull/4577#discussion_r1008532668
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -978,6 +1091,32 @@ private Set<String>
expectedManifestListPaths(Iterable<Snapshot> snapshots, Long
.collect(Collectors.toSet());
}
+ private void createTableAndAddPartitionOnNestedFiled() throws IOException {
Review Comment:
Great to add all these tests. I think it may fit better in
"TestMetadataTablesWithPartitionEvolution" because if i understand its a
partition evolution case? But maybe its too much work to move the new tests
there.
##########
core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java:
##########
@@ -107,13 +107,15 @@ public Schema record(Schema record, List<String> names,
Iterable<Schema.Field> s
field.name());
// Create a field that will be defaulted to null. We assign a unique
suffix to the field
// to make sure that even if records in the file have the field it is
not projected.
+ String fieldName = AvroSchemaUtil.makeCompatibleName(field.name());
Schema.Field newField =
new Schema.Field(
- field.name() + "_r" + field.fieldId(),
+ fieldName + "_r" + field.fieldId(),
AvroSchemaUtil.toOption(AvroSchemaUtil.convert(field.type())),
null,
JsonProperties.NULL_VALUE);
newField.addProp(AvroSchemaUtil.FIELD_ID_PROP, field.fieldId());
+ newField.addProp(AvroSchemaUtil.ICEBERG_FIELD_NAME_PROP, field.name());
Review Comment:
Nit: Can we use fieldName here? (Actually prefer to rename to
'oldFieldName' if you don't mind.
Also , do you know the significance of this property? Looks like in the
other case its only set if the field name has been changed, should we do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
