[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6059: Core,Spark: Fix raw generics usage of ManifestWriter

[GitBox]

ajantha-bhat commented on code in PR #6059:
URL: https://github.com/apache/iceberg/pull/6059#discussion_r1007639523


##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/TestManifestFileSerialization.java:
##########
@@ -199,7 +199,7 @@ private ManifestFile writeManifest(DataFile... files) 
throws IOException {
     Assert.assertTrue(manifestFile.delete());
     OutputFile outputFile = 
FILE_IO.newOutputFile(manifestFile.getCanonicalPath());
 
-    ManifestWriter writer = ManifestFiles.write(SPEC, outputFile);
+    ManifestWriter<DataFile> writer = ManifestFiles.write(SPEC, outputFile);

Review Comment:
   I think we are still missing in 
`TestForwardCompatibility#testSparkCanReadUnknownTransform()`
   
   this is applicable to all 5 versions of spark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org