nastra commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1007091840
##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -135,11 +143,14 @@ public CloseableIterable<FileScanTask> planFiles() {
planningDuration.stop();
ScanReport scanReport =
ImmutableScanReport.builder()
- .projection(schema())
+ .schemaId(schema().schemaId())
+ .projectedFieldIds(projectedFieldIds)
+ .projectedFieldNames(projectedFieldNames)
.tableName(table().name())
.snapshotId(snapshot.snapshotId())
.filter(ExpressionUtil.sanitize(filter()))
.scanMetrics(ScanMetricsResult.fromScanMetrics(scanMetrics()))
+ .metadata(context().options())
Review Comment:
the idea was here to use a fairly generic term since we could also send more
things in the future than just the options that were passed to a scan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
