stevenzwu commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1004796797
########## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink; + +import static org.apache.iceberg.TableProperties.DEFAULT_NAME_MAPPING; + +import java.time.Duration; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.util.TimeUtils; +import org.apache.iceberg.Table; +import org.apache.iceberg.flink.source.StreamingStartingStrategy; + +public class FlinkReadConf { + + private final FlinkConfParser confParser; + + public FlinkReadConf(Map<String, String> readOptions, ReadableConfig readableConfig) { + this.confParser = new FlinkConfParser(null, readOptions, readableConfig); + } + + public FlinkReadConf( + @Nullable Table table, Map<String, String> readOptions, ReadableConfig readableConfig) { + this.confParser = new FlinkConfParser(table, readOptions, readableConfig); + } + + public Long snapshotId() { + return confParser + .longConf() + .option(FlinkReadOptions.SNAPSHOT_ID.key()) + .flinkConfig(FlinkReadOptions.SNAPSHOT_ID) + .parseOptional(); + } + + public Boolean caseSensitive() { + return confParser + .booleanConf() + .option(FlinkReadOptions.CASE_SENSITIVE.key()) + .flinkConfig(FlinkReadOptions.CASE_SENSITIVE) + .defaultValue(FlinkReadOptions.CASE_SENSITIVE.defaultValue()) + .parse(); + } + + public Long asOfTimestamp() { + return confParser + .longConf() + .option(FlinkReadOptions.AS_OF_TIMESTAMP.key()) + .flinkConfig(FlinkReadOptions.AS_OF_TIMESTAMP) + .parseOptional(); + } + + public StreamingStartingStrategy startingStrategy() { + return confParser + .enumConfParser(StreamingStartingStrategy.class) + .option(FlinkReadOptions.STARTING_STRATEGY.key()) + .flinkConfig(FlinkReadOptions.STARTING_STRATEGY) + .defaultValue(StreamingStartingStrategy.INCREMENTAL_FROM_LATEST_SNAPSHOT) + .parse(); + } + + public Long startSnapshotTimestamp() { + return confParser + .longConf() + .option(FlinkReadOptions.START_SNAPSHOT_TIMESTAMP.key()) + .flinkConfig(FlinkReadOptions.START_SNAPSHOT_TIMESTAMP) + .parseOptional(); + } + + public Long startSnapshotId() { + return confParser + .longConf() + .option(FlinkReadOptions.START_SNAPSHOT_ID.key()) + .flinkConfig(FlinkReadOptions.START_SNAPSHOT_ID) + .parseOptional(); + } + + public Long endSnapshotId() { + return confParser + .longConf() + .option(FlinkReadOptions.END_SNAPSHOT_ID.key()) + .flinkConfig(FlinkReadOptions.END_SNAPSHOT_ID) + .parseOptional(); + } + + public Long splitSize() { + return confParser + .longConf() + .option(FlinkReadOptions.SPLIT_SIZE.key()) + .flinkConfig(FlinkReadOptions.SPLIT_SIZE) + .parseOptional(); + } + + public Integer splitLookback() { + return confParser + .intConf() + .option(FlinkReadOptions.SPLIT_LOOKBACK.key()) + .flinkConfig(FlinkReadOptions.SPLIT_LOOKBACK) + .parseOptional(); + } + + public Long splitFileOpenCost() { + return confParser + .longConf() + .option(FlinkReadOptions.SPLIT_FILE_OPEN_COST.key()) + .flinkConfig(FlinkReadOptions.SPLIT_FILE_OPEN_COST) + .parseOptional(); + } + + public Boolean streaming() { Review Comment: `parse` should probably return primitive type as default value is provided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
