nastra commented on code in PR #6006:
URL: https://github.com/apache/iceberg/pull/6006#discussion_r999014587


##########
core/src/main/java/org/apache/iceberg/RowLevelOperationMode.java:
##########
@@ -43,9 +43,9 @@ public enum RowLevelOperationMode {
 
   public static RowLevelOperationMode fromName(String modeName) {

Review Comment:
   +1 to that idea



##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -332,6 +332,8 @@ private TableProperties() {}
   public static final String MERGE_MODE = "write.merge.mode";
   public static final String MERGE_MODE_DEFAULT = "copy-on-write";

Review Comment:
   +1 to that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to