rdblue commented on code in PR #4925: URL: https://github.com/apache/iceberg/pull/4925#discussion_r990854951
########## api/src/main/java/org/apache/iceberg/view/View.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import java.util.List; +import java.util.Map; + +/** Interface for view definition. */ +public interface View { + + String name(); + + /** + * Get the current version for this view, or null if there are no versions. + * + * @return the current view version. + */ + ViewVersion currentVersion(); + + /** + * Get the versions of this view. + * + * @return an Iterable of versions of this view. + */ + Iterable<ViewVersion> versions(); + + /** + * Get a version in this view by ID. + * + * @param versionId version ID + * @return a version, or null if the ID cannot be found + */ + ViewVersion version(long versionId); Review Comment: This should be an `int` to correspond to `ViewHistoryEntry`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
