[GitHub] [iceberg] sumeetgajjar commented on a diff in pull request #5893: Core: Use avro compression properties from table properties while writing Manifest and Manifest list files.

[GitBox]

sumeetgajjar commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r989743754


##########
core/src/test/java/org/apache/iceberg/TestTransaction.java:
##########
@@ -535,7 +535,12 @@ public void testTransactionRetryAndAppendManifests() 
throws Exception {
     // create a manifest append
     OutputFile manifestLocation =
         Files.localOutput("/tmp/" + UUID.randomUUID().toString() + ".avro");
-    ManifestWriter<DataFile> writer = ManifestFiles.write(table.spec(), 
manifestLocation);
+    ManifestWriter<DataFile> writer =
+        ManifestFiles.write(
+            table.spec(),
+            manifestLocation,
+            table.properties().get(TableProperties.AVRO_COMPRESSION),
+            table.properties().get(TableProperties.AVRO_COMPRESSION_LEVEL));

Review Comment:
   Reverted and tried reducing the overall churn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org