jackye1995 commented on code in PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#discussion_r984038524
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -479,6 +480,49 @@ private void applyUpdates(TableOperations underlyingOps) {
// Cannot pass even with retry due to conflicting metadata changes.
So, break the
// retry-loop.
throw new PendingUpdateFailedException(e);
+
+ } catch (ValidationException e) {
+ if (PropertyUtil.propertyAsBoolean(
+ base.properties(),
+ TableProperties.ROLLBACK_COMPACTION_ON_CONFLICTS_ENABLED,
+
TableProperties.ROLLBACK_COMPACTION_ON_CONFLICTS_ENABLED_DEFAULT)) {
Review Comment:
thanks for the update! In that case should we call this something like
`ROLLBACK_REPLACE_ON_CONFLICTS_ENABLED`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
