rizaon commented on code in PR #4518:
URL: https://github.com/apache/iceberg/pull/4518#discussion_r976128390
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -57,6 +58,64 @@ private CatalogProperties() {}
public static final long CACHE_EXPIRATION_INTERVAL_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(30);
public static final long CACHE_EXPIRATION_INTERVAL_MS_OFF = -1;
+ /**
+ * Controls whether to use {@link ContentCache} during manifest file reads
or not.
+ *
+ * <p>This value will be ignored and the file cache will be disabled if any
of the following is
+ * true:
+ *
+ * <ul>
+ * <li>{@link #IO_CACHE_EXPIRATION_INTERVAL_MS} is set to negative number.
+ * <li>{@link #IO_CACHE_MAX_TOTAL_BYTES} is set to non-positive value.
+ * <li>{@link #IO_CACHE_MAX_CONTENT_LENGTH} is set to non-positive value.
+ * </ul>
+ */
+ public static final String IO_CACHE_ENABLED = "io.cache-enabled";
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
