stevenzwu commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r960607115
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
##########
@@ -233,7 +233,31 @@ public void testBoundedStreamCloseWithEmittingDataFiles()
throws Exception {
Assert.assertEquals(expectedDataFiles * 2, result.dataFiles().length);
}
}
+ @Test
+ public void testBoundedStreamTriggeredEndInputBeforeTriggeringCheckpoint()
throws Exception {
+ try (OneInputStreamOperatorTestHarness<RowData, WriteResult> testHarness =
+ createIcebergStreamWriter()) {
+ testHarness.processElement(SimpleDataUtil.createRowData(1, "hello"), 1);
+ testHarness.processElement(SimpleDataUtil.createRowData(2, "world"), 2);
+
+ // The EndInput is triggered first
Review Comment:
nit: this comment is not useful. we can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
