[GitHub] [iceberg] kbendick commented on issue #5676: Core: Dropping an old partition column causes NPE (and corrupt metadata on v2 tables)

[GitBox]

kbendick commented on issue #5676:
URL: https://github.com/apache/iceberg/issues/5676#issuecomment-1233821181

   All of the examples of `REPLACE PARTITION FIELD` seem to be a transform of 
the same type:
   
   Here's the actual SQL definition:
   ```
   
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
   72:    | ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform 
WITH transform (AS name=identifier)? #replacePartitionField
   ```
   
   But here's the examples I could find:
   ```
   
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java
   307:    sql("ALTER TABLE %s REPLACE PARTITION FIELD days(ts) WITH 
hours(ts)", tableName);
   333:    sql("ALTER TABLE %s REPLACE PARTITION FIELD days(ts) WITH hours(ts) 
AS hour_col", tableName);
   359:    sql("ALTER TABLE %s REPLACE PARTITION FIELD day_col WITH hours(ts)", 
tableName);
   385:    sql("ALTER TABLE %s REPLACE PARTITION FIELD day_col WITH hours(ts) 
AS hour_col", tableName);
   ```
   
   But this does seem like a bug. Did this still happen if the table was 
refreshed in between alter table statements?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org