jaideeppyne commented on PR #3976: URL: https://github.com/apache/iceberg-python/pull/3976#issuecomment-7055141529
Resolved the merge conflict with current main in e4bd421. `commit_table` still puts a table-scoped token on that request only, and it now also sends `_mutation_headers()`. The session headers are not written. Main already registers a custom S3 signer on a private aiobotocore session, so I kept that instead of the older `skip_instance_cache` workaround. `test_commit_table_does_not_mutate_session_headers`, `test_table_identifier_in_commit_table_request`, and the two per-session signer tests pass locally. Please keep this open for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
