SAMARTHJAISWAL commented on PR #3717: URL: https://github.com/apache/iceberg-rust/pull/3717#issuecomment-7042997365
Thanks for checking it against Java and through the reader. I'd keep matching Java here, because it also matches what the binary path in this file already does: `b != 2147483648` on an int column binds to `AlwaysTrue` (the `AboveMax` / `NotEq` arm just above), and so does `NOT IN` with an empty list. With this change `b NOT IN (2147483648, 2147483649)` binds the same way as `b != 2147483648`, so the two stay consistent with each other. The NULL difference you saw is real, but it comes from folding to `AlwaysTrue` in general rather than from this PR. Binding to `IS NOT NULL` for optional fields would need the same change for `!=` to stay consistent, and it would diverge from Java, so I think it belongs in a separate issue if maintainers want it. Happy to change it here if they prefer that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
