flyrain commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r4618538444
########## format/view-spec.md: ########## @@ -160,7 +179,95 @@ Each entry in `version-log` is a struct with the following fields: | _required_ | `timestamp-ms` | Timestamp when the view's `current-version-id` was updated (ms from epoch) | | _required_ | `version-id` | ID that `current-version-id` was set to | -## Appendix A: An Example +#### Storage Table Identifier + +The table identifier for the storage table that stores the precomputed results. + +| Requirement | Field name | Description | +|-------------|----------------|-------------| +| _required_ | `namespace` | A list of strings for namespace levels | +| _required_ | `name` | A string specifying the name of the table | +| _optional_ | `catalog` | A string specifying the name of the catalog. When `null` or not set, the catalog in which the materialized view is stored is used | Review Comment: The same catalog could have different names from different engines, or the same engine with different configures. For example, a IRC catalog can be configured as `prod` in Spark, and as `marketing` in Trino. If we put a `marketing` here as the optional `catalog`, how does it work with engines with different names? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
