AynSiddiqui commented on PR #2624: URL: https://github.com/apache/iceberg-go/pull/2624#issuecomment-6984476259
I re-ran my local tests at 6655a714. Two cases beyond the upgrade ones already covered here: if a peer commit lands while a delete that removes a legacy position-delete file is staged, the commit fails with `ErrCommitFailed` and retrying the delete succeeds; and an equality delete stays live next to the new DV. I also applied #2639 (the v2 position-delete spec fix for #2606) on top. There are no conflicts and `go test ./table/...` passes. With a v2 delete after a spec change, then the upgrade and a v3 delete, the DV keeps the data file's spec and partition and the scans return `[2 3]` and then `[3]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
