JeonDaehong commented on code in PR #18993:
URL: https://github.com/apache/iceberg/pull/18993#discussion_r4616276673


##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -303,13 +303,24 @@ private static void 
validateDeleteFileForVersion(DeleteFile file, int formatVers
             ContentFileUtil.dvDesc(file));
         break;
       case 3:
-      case 4:
         Preconditions.checkArgument(
             file.content() == FileContent.EQUALITY_DELETES || 
ContentFileUtil.isDV(file),
             "Must use DVs for position deletes in V%s: %s",
             formatVersion,
             file.location());
         break;
+      case 4:
+        Preconditions.checkArgument(

Review Comment:
   Thanks, the new cases pass on 0609498, and replacing a legacy equality 
delete with a DV still going through is a nice thing to have pinned down.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to