pvary commented on code in PR #18424:
URL: https://github.com/apache/iceberg/pull/18424#discussion_r4616113629


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -343,7 +343,22 @@ protected void doCommit(TableMetadata base, TableMetadata 
metadata) {
                 + "iceberg.hive.lock-heartbeat-interval-ms.",
             le);
       } catch (org.apache.hadoop.hive.metastore.api.AlreadyExistsException e) {
-        throw new AlreadyExistsException(e, "Table already exists: %s.%s", 
database, tableName);
+        // A create_table resent after a lost response fails on the table its 
first attempt created

Review Comment:
   nit: better explanation for this double check would be nice. Keep it short 
but tell future developers why it is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to