ump45nose commented on PR #3485:
URL: https://github.com/apache/iceberg-rust/pull/3485#issuecomment-6977969201

   The three test findings are addressed in `fbe43f37`.
   
   - `FileScanTask` now takes both `file_size_in_bytes` and `length` from the 
written file's metadata; `length(0)` described an empty task while the size 
field named the whole file.
   - The day/microsecond/nanosecond conversions go through `MICROS_PER_DAY` and 
`NANOS_PER_MICRO` in the test module instead of literals.
   - The temporary file path is built with `Path::join` and converted once for 
the `String` field, instead of `format!("{}/…")` on a `to_str().unwrap()`.
   
   Local: `cargo test -p iceberg --lib arrow::reader::projection` → 23 passed, 
`cargo fmt -p iceberg -- --check` clean, `cargo clippy -p iceberg --all-targets 
-- -D warnings` clean.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to