Anurag-S1ngh commented on PR #4406:
URL: https://github.com/apache/iceberg-python/pull/4406#issuecomment-6976630004
Thanks for the review. Addressed in c6e658d2, 1b28eb2f and 68dc05be:
- `era` is now `z // 146097`, and `(-719529, -1971, -23641)` is in the
parametrized test.
- Added `test_scan_and_delete_filters_on_infinity` for `<`, `<=`, `>`, `>=`
and `delete(LessThan("x", math.inf))`.
- The description now lists the range and delete behavior change and the
divergence from Java's `DoubleLiteral.to(FLOAT)`.
- Dropped the unreachable `nanos_to_*` asserts.
`StringLiteral` with `"Infinity"` is left as a follow-up. I'll rebase once
#4407, #4401 or #4402 lands and the `test_pyarrow.py` conflict appears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]