iceberg-kitten commented on code in PR #2591: URL: https://github.com/apache/iceberg-go/pull/2591#discussion_r4612272131
########## website/src/releases.md: ########## @@ -45,6 +45,7 @@ Per-release notes (highlights, breaking changes, contributors) are published on - **Data-file replacements now reject concurrent deletes.** Commits staged through `ReplaceDataFiles`, `ReplaceDataFilesByPath`, `ReplaceFiles`, or rewrite operations can return `table.ErrConflictingDeleteFiles` when a concurrent position delete targets a replaced file or any concurrent equality delete is added. Compaction on tables with streaming equality deletes may see additional conflicts. - **Orphan cleanup now rejects `gc.enabled=false`.** `DeleteOrphanFiles`, `PlanOrphanFiles`, `ExecuteOrphanCleanup`, and dry runs now return an error before filesystem access. The `iceberg clean-orphan-files` command is also affected. - **Partition specs reject source types a transform cannot handle.** Creating or updating a spec with an incompatible source, such as `day(string)`, now fails. Writes to existing incompatible specs return `ErrInvalidTransform` instead of writing null partition values. +- **New partition specs reject multiple sources for built-in transforms.** Create-table and add-spec payloads with this shape return `ErrInvalidPartitionSpec`. Historical metadata with such a field still loads and round-trips, but the field is skipped during partition pruning and residual simplification. Multi-source unknown transforms remain supported. Review Comment: Added the REST error to the release notes. CI is green. ########## website/src/releases.md: ########## @@ -45,6 +45,7 @@ Per-release notes (highlights, breaking changes, contributors) are published on - **Data-file replacements now reject concurrent deletes.** Commits staged through `ReplaceDataFiles`, `ReplaceDataFilesByPath`, `ReplaceFiles`, or rewrite operations can return `table.ErrConflictingDeleteFiles` when a concurrent position delete targets a replaced file or any concurrent equality delete is added. Compaction on tables with streaming equality deletes may see additional conflicts. - **Orphan cleanup now rejects `gc.enabled=false`.** `DeleteOrphanFiles`, `PlanOrphanFiles`, `ExecuteOrphanCleanup`, and dry runs now return an error before filesystem access. The `iceberg clean-orphan-files` command is also affected. - **Partition specs reject source types a transform cannot handle.** Creating or updating a spec with an incompatible source, such as `day(string)`, now fails. Writes to existing incompatible specs return `ErrInvalidTransform` instead of writing null partition values. +- **New partition specs reject multiple sources for built-in transforms.** Create-table and add-spec payloads with this shape return `ErrInvalidPartitionSpec`. Historical metadata with such a field still loads and round-trips, but the field is skipped during partition pruning and residual simplification. Multi-source unknown transforms remain supported. Review Comment: Added the REST error to the release notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
