Shruthirdy commented on code in PR #2585:
URL: https://github.com/apache/iceberg-go/pull/2585#discussion_r4605762689


##########
schema.go:
##########
@@ -422,7 +435,7 @@ func (s *Schema) UnmarshalJSON(b []byte) error {
                return fmt.Errorf("%w: invalid schema fields: %w", 
ErrInvalidSchema, err)
        }
 
-       if err := checkDuplicateFieldIDs(nil, fields); err != nil {
+       if err := checkAllDuplicateFieldIDs(fields); err != nil {

Review Comment:
   Thank you @badalprasadsingh for review. Both builders now reject duplicate 
IDs, with catalog tests for `CommitTable`, `CreateView` and `UpdateView`. The 
view package has its own small copy of the check (happy to change the approach 
if you prefer)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to