stevenzwu commented on code in PR #19007:
URL: https://github.com/apache/iceberg/pull/19007#discussion_r4605083234


##########
core/src/test/java/org/apache/iceberg/TestV4ManifestWriter.java:
##########
@@ -161,6 +162,61 @@ class TestV4ManifestWriter {
           List.of(4L),
           List.of(COLUMN_FILE_A));
 
+  private static final ColumnFile REPLACE_DV_COLUMNS =
+      new ColumnFileStruct(
+          "s3://bucket/db/table/data/leaf-40-1-dv-update.parquet",
+          Set.of(TrackedFile.DELETION_VECTOR.fieldId(), 
TrackedFile.TIGHT_STATS.fieldId()),
+          FileFormat.PARQUET,
+          512,
+          null);
+
+  // a generic manifest info; row count = 100 * file count
+  private static final ManifestInfo MANIFEST_INFO =
+      new ManifestInfoStruct(2, 10, 2, 4, 4, 200, 1_000, 200, 400, 400, 34L, 
null /* MDV */, 4);
+
+  private static final ManifestBitmap MDV = 
MumblingBitmaps.newMutableBitmap(4, 8, 12);
+
+  private static final ManifestInfo MANIFEST_INFO_WITH_MDV =
+      new ManifestInfoStruct(2, 10, 2, 4, 4, 200, 1_000, 200, 400, 400, 34L, 
MDV, 4);
+
+  private static final TrackedFile LEAF_MANIFEST =
+      new TrackedFileStruct(
+          new TrackingStruct(EntryStatus.EXISTING, 40L, 35L, 35L, null, 500L, 
null, null),
+          FileContent.DATA_MANIFEST,
+          "s3://bucket/db/table/metadata/leaf-40-1.parquet",
+          FileFormat.PARQUET,
+          100,
+          1024,
+          null, // unpartitioned
+          null, // unpartitioned
+          CONTENT_STATS_A,
+          false,
+          null, // no sort order for manifests
+          null, // no external DV for manifests,

Review Comment:
   nit: I was also suggesting `no external DV` -> `no data DV` because 
`external DV` can be mis-interpreted as external manifest DV.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to