zeroshade commented on code in PR #2623: URL: https://github.com/apache/iceberg-go/pull/2623#discussion_r4603798287
########## internal/bound_predicate_ref.go: ########## @@ -17,6 +17,6 @@ package internal -// BoundPredicateRef authorizes the zero-copy bound-predicate visitor path for -// trusted visitors in this module. +// BoundPredicateRef is the parameter type of the BorrowBoundSets marker, Review Comment: Nit: the gate only holds while no exported signature mentions `BoundPredicateRef`. Any exported func or method that takes one would bring back the inference hole that `VisitBoundPredicateRef` had. Could the comment say that, so a later change doesn't reopen it by accident? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
