rahulsmahadev commented on code in PR #17622:
URL: https://github.com/apache/iceberg/pull/17622#discussion_r4601855988
##########
api/src/main/java/org/apache/iceberg/actions/RepairTable.java:
##########
@@ -33,6 +33,10 @@ public interface RepairTable extends
SnapshotUpdate<RepairTable, RepairTable.Res
* Repairs incorrect metrics of manifest entries, such as record counts,
file sizes and column
* level statistics, by comparing them against the underlying data and
delete files.
*
+ * <p>Deletion vectors (delete blobs stored in Puffin files) are not
verified or repaired. Metrics
+ * that cannot be reconstructed from files are kept as stored: NaN counts
and the bounds of float,
Review Comment:
Agreed, it now just says these are preserved, and I made the Spark action's
class javadoc and the comment in `RepairMetrics` match. Recovering them from
footer statistics when they're present sounds like a good follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]