blackmwk commented on code in PR #2396: URL: https://github.com/apache/iceberg-rust/pull/2396#discussion_r4597683483
########## crates/catalog/glue/src/catalog.rs: ########## Review Comment: I'm thinking adopting a SessionCatalog design similar to what we did for RestSessionCatalog, WDYT? ########## crates/integrations/aws/Cargo.toml: ########## Review Comment: I think having a common `iceberg-aws` crate is the right direction, but I feel this repo is not well organized. For example, I hope to see sth like `AwsProperties` to have a strongly typed data structure for aws common configs, and you could take `TableProperties` as reference. Also please put different data structures into different modes like credentials. ########## crates/integrations/aws/Cargo.toml: ########## Review Comment: Also we miss a README.md to explain what this crate is used for. ########## crates/integrations/aws/Cargo.toml: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +edition = { workspace = true } +homepage = { workspace = true } +name = "iceberg-aws" +rust-version = { workspace = true } +version = { workspace = true } Review Comment: We need to publish it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
