Fokko commented on code in PR #4400:
URL: https://github.com/apache/iceberg-python/pull/4400#discussion_r4600032781
##########
tests/io/test_pyarrow.py:
##########
@@ -1953,6 +1954,46 @@ def
test_projection_filter_on_unprojected_field(schema_int_str: Schema, file_int
assert repr(result_table.schema) == "id: int32 not null"
+def test_projection_null_filter_on_list_and_map(tmpdir: str) -> None:
Review Comment:
I think this test is hard to read, and it only tests a specific part of the
code. How about having something similar as reported in the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]