Rahul-cs50 commented on PR #4219: URL: https://github.com/apache/iceberg-python/pull/4219#issuecomment-6946099242
Pushed 88075cd with the two changes from your review: the collector now tracks only NaN terms (renamed `_NaNUnmentionedTermsCollector`), and `test_expression_to_complementary_pyarrow` checks which rows the complement keeps on a small table instead of the expression repr. The NaN branch stays for the follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
