pvary commented on code in PR #18484:
URL: https://github.com/apache/iceberg/pull/18484#discussion_r4597301931
##########
data/src/main/java/org/apache/iceberg/data/GenericDeleteFilter.java:
##########
@@ -22,25 +22,39 @@
import org.apache.iceberg.FileScanTask;
import org.apache.iceberg.Schema;
import org.apache.iceberg.StructLike;
+import org.apache.iceberg.encryption.InputFilesDecryptor;
import org.apache.iceberg.io.FileIO;
import org.apache.iceberg.io.InputFile;
public class GenericDeleteFilter extends DeleteFilter<Record> {
private final Function<String, InputFile> inputFileProvider;
private final InternalRecordWrapper asStructLike;
+ /**
+ * @deprecated since 1.13.0, will be removed in 1.14.0; use {@link
+ * #GenericDeleteFilter(InputFilesDecryptor, FileScanTask, Schema,
Schema)} instead.
+ */
+ @Deprecated
public GenericDeleteFilter(
FileIO io, FileScanTask task, Schema tableSchema, Schema
requestedSchema) {
this(io::newInputFile, task, tableSchema, requestedSchema);
}
- GenericDeleteFilter(
- Function<String, InputFile> inputFileProvider,
+ public GenericDeleteFilter(
+ InputFilesDecryptor decryptor,
+ FileScanTask task,
+ Schema tableSchema,
+ Schema requestedSchema) {
+ this(decryptor::getInputFile, task, tableSchema, requestedSchema);
+ }
+
+ private GenericDeleteFilter(
+ Function<String, InputFile> inputFiles,
FileScanTask task,
Schema tableSchema,
Schema requestedSchema) {
super(task.file().location(), task.deletes(), tableSchema,
requestedSchema);
- this.inputFileProvider = inputFileProvider;
Review Comment:
nit: Why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]