nisan1101 commented on code in PR #2590:
URL: https://github.com/apache/iceberg-go/pull/2590#discussion_r4596478746


##########
table/update_schema.go:
##########
@@ -1101,7 +1101,7 @@ func (u *UpdateSchema) BuildUpdates() ([]Update, 
[]Requirement, error) {
                        updates = append(
                                updates,
                                NewAddSchemaUpdate(newSchema),
-                               NewSetCurrentSchemaUpdate(newSchema.ID),
+                               NewSetCurrentSchemaUpdate(-1),

Review Comment:
   Yeah Java clients hit the same failure. It is better to fail loudly in the 
equivalent-schema case than silently in the different-schema case. Added a 
comment at the call site and a note on the equivalent schema subtest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to