dannycjones commented on PR #3525: URL: https://github.com/apache/iceberg-rust/pull/3525#issuecomment-6933803696
> b. question(non-blocking): [@dannycjones](https://github.com/dannycjones) Whats the motivation for [#3524](https://github.com/apache/iceberg-rust/issues/3524)? pure cleanup? maintainability? or are we supporting a use case? My key motivation is that its clear in code reviews to anyone scanning the code what we're mapping between when we have `HashMap<IcebergFieldId, ArrowColumnIndex`, etc.. I've been working on changes for V3 data types and muddling with the Arrow layer a lot, and its confusing as hell with maps between u32 and i64. There's extra benefits in terms of maintainability and consistency of course, but my main concern is real person readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
