amogh-jahagirdar commented on code in PR #17642:
URL: https://github.com/apache/iceberg/pull/17642#discussion_r4592856640


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3036,7 +3115,14 @@ components:
           format: int64
         manifest-list:
           type: string
-          description: Location of the snapshot's manifest list file
+          description:
+            Location of the snapshot's manifest list file.
+            Used for format versions 1-3 and must be absent for format version 
4, which uses `root-manifest` instead.

Review Comment:
   format version 4 and higher? Just a bit of future proofing



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5356,13 +5482,22 @@ components:
           nullable: true
 
     CommitTableResponse:
+      description: |
+        Result used when a table is successfully updated, for tables at any 
format version.
+
+
+        The `table-location` field carries the table's base location, so that 
a client can resolve relative paths in the returned metadata.
       type: object
       required:
-        - metadata-location
         - metadata
       properties:
         metadata-location:
           type: string
+          description:
+            Location of the committed table metadata file.
+            Absent when the table has no client-visible metadata location, as 
for a catalog-managed table where the catalog is the source of truth for table 
state.

Review Comment:
   I think we should avoid the "catalog-managed" table jargon, all tables are 
catalog managed in iceberg



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3036,7 +3115,14 @@ components:
           format: int64
         manifest-list:
           type: string
-          description: Location of the snapshot's manifest list file
+          description:
+            Location of the snapshot's manifest list file.
+            Used for format versions 1-3 and must be absent for format version 
4, which uses `root-manifest` instead.
+        root-manifest:
+          type: string
+          description:
+            Location of the snapshot's root manifest.
+            Required for format version 4 and must be absent for format 
versions 1-3.

Review Comment:
   Same as above 4 and higher?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to