nssalian commented on code in PR #29: URL: https://github.com/apache/iceberg-verification/pull/29#discussion_r4592354390
########## reference-tables/v2/primitive-types-parquet-data/README.md: ########## @@ -0,0 +1,189 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +# v2/primitive-types-parquet-data + +Input to `reference-tables/GenerateTables.java`. The schema and partition spec are +the spec's JSON forms. The one commit appends one data file holding its rows, +written in the spec's single-value JSON keyed by field ID, with `long` values as +strings. + +The table holds one column of every v1 and v2 primitive type. The three decimal +columns use each of the Parquet physical types the spec maps a decimal to: +`int32` for precision up to 9, `int64` up to 18, and `fixed_len_byte_array` +otherwise. A reader that decodes only one of them fails on the others. The +`timestamp` and `timestamptz` columns differ only in the `TIMESTAMP_MICROS` +annotation's `isAdjustedToUTC` flag, so a reader that ignores the flag returns +one of them with the wrong type, or shifted by its local zone. Review Comment: nit: `timestamp_col` and `timestamptz_col` hold the same micros in the file, and the Procedure decodes each column by its type in the Iceberg schema. A reader that ignores `isAdjustedToUTC` but takes the type from the schema still returns the right rows, and a zone shift only shows when the check runs outside UTC. Could this sentence say the check should run in a non-UTC zone, or limit the claim to readers that take the type from the Parquet annotation? ########## reference-tables/README.md: ########## @@ -230,7 +230,10 @@ a read of each snapshot's live data files with no Iceberg library: its manifest list, each manifest's entries not marked `DELETED`, and the rows of each data file those entries name, less the positions any deletion vector that applies to it deletes. The rows of `v3/deletion-vector-parquet-data` were instead derived -from its Input, and a PyIceberg 0.12.0 scan returns the same rows. +from its Input, and a PyIceberg 0.12.0 scan returns the same rows. The rows of +`v2/primitive-types-parquet-data` were also derived from its Input, then checked +against the same read with no Iceberg library and against scans with PyIceberg, +Iceberg Java, iceberg-go and iceberg-rust. Review Comment: nit: the sentence before pins PyIceberg 0.12.0, could this one carry the versions too (PyIceberg 0.12.0, Java 1.11.0 and 1.12.0, iceberg-go a9e2cc3, iceberg-rust 0.11.0)? Right now they're only in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
