smaheshwar-pltr commented on code in PR #18798:
URL: https://github.com/apache/iceberg/pull/18798#discussion_r4592082921


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -542,6 +542,12 @@ private static boolean hiveLockEnabled(TableMetadata 
metadata, Configuration con
   }
 
   private void encryptionPropsFromMetadata(Map<String, String> 
tableProperties) {
+    // Encryption properties of an existing table come from HMS. Uncommitted 
metadata only

Review Comment:
   Yes the above is my understanding. (I've now tried to make that clearer in 
https://github.com/apache/iceberg/pull/18798/commits/0f1a2d848f263885b4bae309ada718de08a478ec)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to