Admaing commented on issue #17019:
URL: https://github.com/apache/iceberg/issues/17019#issuecomment-6916792985

   Confirmed on current main: the standalone `tableSession(RESTClient, Map)` 
still builds the parent session from `OAuth2Util.authHeaders(config.token())` 
only, so configured `header.*` properties are dropped, and 
`newSessionFromTokenResponse` calls `OAuth2Util.fetchToken` with `Map.of()`.
   
   Note that #17021 already contained a fix for the first gap and was closed by 
the stale bot on 2026-09-10 — its author re-checked main afterwards and the gap 
was still there.
   
   I have a patch ready that merges `RESTUtil.configHeaders(properties)` into 
the parent headers (the auth header wins on collision) and also forwards 
`parent.headers()` to the token fetch, which #17021 did not cover. Tests cover 
both the provided-token path and the client-credentials path; both fail before 
the change.
   
   @hutiefang76 are you still planning to bring #17021 back? If you'd rather 
take it, I'm happy to review instead, or to credit you as co-author if you'd 
like me to carry the patch forward. Otherwise I'll open mine in a few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to