laskoviymishka commented on code in PR #18062:
URL: https://github.com/apache/iceberg/pull/18062#discussion_r4583330912


##########
site/docs/status.md:
##########
@@ -27,188 +27,249 @@ capabilities.
 
 This section lists the libraries that implement the Apache Iceberg 
specification.
 
-- [Java](https://mvnrepository.com/artifact/org.apache.iceberg)
-- [PyIceberg](https://pypi.org/project/pyiceberg/)
-- [Rust](https://crates.io/crates/iceberg)
-- [Go](https://pkg.go.dev/github.com/apache/iceberg-go)
-- [C++](https://github.com/apache/iceberg-cpp/releases)
+| Library | Released Version |
+|---------|------------------|
+| [Java](https://mvnrepository.com/artifact/org.apache.iceberg) | 
[1.12.0](https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.12.0) |
+| [PyIceberg](https://pypi.org/project/pyiceberg/) | 
[0.12.0](https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.12.0)
 |
+| [Rust](https://crates.io/crates/iceberg) | 
[0.11.0](https://github.com/apache/iceberg-rust/releases/tag/v0.11.0) |
+| [Go](https://pkg.go.dev/github.com/apache/iceberg-go) | 
[0.7.0](https://github.com/apache/iceberg-go/releases/tag/v0.7.0) |
+| [C++](https://github.com/apache/iceberg-cpp/releases) | 
[0.4.0](https://github.com/apache/iceberg-cpp/releases/tag/v0.4.0) |
 
 ## Data Types
 
-| Data Type      | Java | PyIceberg | Rust | Go | C++ |
-|----------------|------|-----------|------|----|-----|
-| boolean        | Y    | Y         | Y    | Y  | Y   |
-| int            | Y    | Y         | Y    | Y  | Y   |
-| long           | Y    | Y         | Y    | Y  | Y   |
-| float          | Y    | Y         | Y    | Y  | Y   |
-| double         | Y    | Y         | Y    | Y  | Y   |
-| decimal        | Y    | Y         | Y    | Y  | Y   |
-| date           | Y    | Y         | Y    | Y  | Y   |
-| time           | Y    | Y         | Y    | Y  | Y   |
-| timestamp      | Y    | Y         | Y    | Y  | Y   |
-| timestamptz    | Y    | Y         | Y    | Y  | Y   |
-| timestamp_ns   | Y    | Y         | Y    | Y  | N   |
-| timestamptz_ns | Y    | Y         | Y    | Y  | N   |
-| unknown        | Y    | Y         | N    | Y  | N   |
-| string         | Y    | Y         | Y    | Y  | Y   |
-| uuid           | Y    | Y         | Y    | Y  | N   |
-| fixed          | Y    | Y         | Y    | Y  | Y   |
-| binary         | Y    | Y         | Y    | Y  | Y   |
-| variant        | Y    | Y         | Y    | Y  | N   |
-| geometry       | Y    | N         | N    | N  | N   |
-| geography      | Y    | N         | N    | N  | N   |
-| list           | Y    | Y         | Y    | Y  | Y   |
-| map            | Y    | Y         | Y    | Y  | Y   |
-| struct         | Y    | Y         | Y    | Y  | Y   |
+`Y` means the library supports the type in schemas and can both read and write 
its values in at least one supported data file
+format. `N` means one or more of these capabilities is missing. For example, 
recognizing `geometry` in a schema without being
+able to read and write geometry values is `N`. Table-format write support is 
listed under Table Write Operations.

Review Comment:
   Could the legend cover the rest of the page too? It only sits under Data 
Types, so the format, operation and catalog tables have no stated rule 
(PyIceberg Puffin `N` next to deletion-vector reads `Y`), and the released-only 
rule from the PR description isn't on the page.
   
   ```suggestion
   able to read and write geometry values is `N`. Table-format write support is 
listed under Table Write Operations.
   
   In the other tables, `Y` means the released version listed above supports 
the capability (for file formats, both read and
   write); support that exists only on `main` is `N`. A tab labeled with a 
version range, such as "V1 - V3", means the table is
   identical for those versions.
   ```



##########
site/docs/status.md:
##########
@@ -27,188 +27,249 @@ capabilities.
 
 This section lists the libraries that implement the Apache Iceberg 
specification.
 
-- [Java](https://mvnrepository.com/artifact/org.apache.iceberg)
-- [PyIceberg](https://pypi.org/project/pyiceberg/)
-- [Rust](https://crates.io/crates/iceberg)
-- [Go](https://pkg.go.dev/github.com/apache/iceberg-go)
-- [C++](https://github.com/apache/iceberg-cpp/releases)
+| Library | Released Version |
+|---------|------------------|
+| [Java](https://mvnrepository.com/artifact/org.apache.iceberg) | 
[1.12.0](https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.12.0) |
+| [PyIceberg](https://pypi.org/project/pyiceberg/) | 
[0.12.0](https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.12.0)
 |
+| [Rust](https://crates.io/crates/iceberg) | 
[0.11.0](https://github.com/apache/iceberg-rust/releases/tag/v0.11.0) |
+| [Go](https://pkg.go.dev/github.com/apache/iceberg-go) | 
[0.7.0](https://github.com/apache/iceberg-go/releases/tag/v0.7.0) |
+| [C++](https://github.com/apache/iceberg-cpp/releases) | 
[0.4.0](https://github.com/apache/iceberg-cpp/releases/tag/v0.4.0) |
 
 ## Data Types
 
-| Data Type      | Java | PyIceberg | Rust | Go | C++ |
-|----------------|------|-----------|------|----|-----|
-| boolean        | Y    | Y         | Y    | Y  | Y   |
-| int            | Y    | Y         | Y    | Y  | Y   |
-| long           | Y    | Y         | Y    | Y  | Y   |
-| float          | Y    | Y         | Y    | Y  | Y   |
-| double         | Y    | Y         | Y    | Y  | Y   |
-| decimal        | Y    | Y         | Y    | Y  | Y   |
-| date           | Y    | Y         | Y    | Y  | Y   |
-| time           | Y    | Y         | Y    | Y  | Y   |
-| timestamp      | Y    | Y         | Y    | Y  | Y   |
-| timestamptz    | Y    | Y         | Y    | Y  | Y   |
-| timestamp_ns   | Y    | Y         | Y    | Y  | N   |
-| timestamptz_ns | Y    | Y         | Y    | Y  | N   |
-| unknown        | Y    | Y         | N    | Y  | N   |
-| string         | Y    | Y         | Y    | Y  | Y   |
-| uuid           | Y    | Y         | Y    | Y  | N   |
-| fixed          | Y    | Y         | Y    | Y  | Y   |
-| binary         | Y    | Y         | Y    | Y  | Y   |
-| variant        | Y    | Y         | Y    | Y  | N   |
-| geometry       | Y    | N         | N    | N  | N   |
-| geography      | Y    | N         | N    | N  | N   |
-| list           | Y    | Y         | Y    | Y  | Y   |
-| map            | Y    | Y         | Y    | Y  | Y   |
-| struct         | Y    | Y         | Y    | Y  | Y   |
+`Y` means the library supports the type in schemas and can both read and write 
its values in at least one supported data file
+format. `N` means one or more of these capabilities is missing. For example, 
recognizing `geometry` in a schema without being
+able to read and write geometry values is `N`. Table-format write support is 
listed under Table Write Operations.
+
+### Table Spec
+
+=== "V1 - V2"
+    | Data Type   | Java | PyIceberg | Rust | Go | C++ |
+    |-------------|------|-----------|------|----|-----|
+    | boolean     | Y    | Y         | Y    | Y  | Y   |
+    | int         | Y    | Y         | Y    | Y  | Y   |
+    | long        | Y    | Y         | Y    | Y  | Y   |
+    | float       | Y    | Y         | Y    | Y  | Y   |
+    | double      | Y    | Y         | Y    | Y  | Y   |
+    | decimal     | Y    | Y         | Y    | Y  | Y   |
+    | date        | Y    | Y         | Y    | Y  | Y   |
+    | time        | Y    | Y         | Y    | Y  | Y   |
+    | timestamp   | Y    | Y         | Y    | Y  | Y   |
+    | timestamptz | Y    | Y         | Y    | Y  | Y   |
+    | string      | Y    | Y         | Y    | Y  | Y   |
+    | uuid        | Y    | Y         | Y    | Y  | Y   |
+    | fixed       | Y    | Y         | Y    | Y  | Y   |
+    | binary      | Y    | Y         | Y    | Y  | Y   |
+    | list        | Y    | Y         | Y    | Y  | Y   |
+    | map         | Y    | Y         | Y    | Y  | Y   |
+    | struct      | Y    | Y         | Y    | Y  | Y   |
+
+=== "V3"
+    | Data Type      | Java | PyIceberg | Rust | Go | C++ |
+    |----------------|------|-----------|------|----|-----|
+    | boolean        | Y    | Y         | Y    | Y  | Y   |
+    | int            | Y    | Y         | Y    | Y  | Y   |
+    | long           | Y    | Y         | Y    | Y  | Y   |
+    | float          | Y    | Y         | Y    | Y  | Y   |
+    | double         | Y    | Y         | Y    | Y  | Y   |
+    | decimal        | Y    | Y         | Y    | Y  | Y   |
+    | date           | Y    | Y         | Y    | Y  | Y   |
+    | time           | Y    | Y         | Y    | Y  | Y   |
+    | timestamp      | Y    | Y         | Y    | Y  | Y   |
+    | timestamptz    | Y    | Y         | Y    | Y  | Y   |
+    | timestamp_ns   | Y    | Y         | Y    | Y  | Y   |
+    | timestamptz_ns | Y    | Y         | Y    | Y  | Y   |
+    | unknown        | Y    | Y         | N    | Y  | Y   |
+    | string         | Y    | Y         | Y    | Y  | Y   |
+    | uuid           | Y    | Y         | Y    | Y  | Y   |
+    | fixed          | Y    | Y         | Y    | Y  | Y   |
+    | binary         | Y    | Y         | Y    | Y  | Y   |
+    | variant        | Y    | N         | N    | Y  | N   |
+    | geometry       | Y    | N         | N    | Y  | Y   |
+    | geography      | Y    | N         | N    | Y  | Y   |
+    | list           | Y    | Y         | Y    | Y  | Y   |
+    | map            | Y    | Y         | Y    | Y  | Y   |
+    | struct         | Y    | Y         | Y    | Y  | Y   |
+
+## Table Metadata and Features
+
+### Table Spec
+
+=== "V1 - V2"
+    | Capability           | Java | PyIceberg | Rust | Go | C++ |
+    |----------------------|------|-----------|------|----|-----|
+    | Read table metadata  | Y    | Y         | Y    | Y  | Y   |
+    | Write table metadata | Y    | Y         | Y    | Y  | Y   |
+
+=== "V3"
+    | Capability                      | Java | PyIceberg | Rust | Go | C++ |
+    |---------------------------------|------|-----------|------|----|-----|
+    | Read table metadata             | Y    | Y         | Y    | Y  | Y   |
+    | Write table metadata            | Y    | N         | Y    | Y  | Y   |
+    | Read initial column defaults    | Y    | Y         | Y    | Y  | Y   |
+    | Read multi-argument transforms  | N    | N         | N    | N  | N   |
+    | Write multi-argument transforms | N    | N         | N    | N  | N   |
+    | Read row lineage columns        | Y    | N         | Y    | Y  | Y   |
+    | Write row lineage               | Y    | N         | Y    | Y  | Y   |
+    | Read encrypted tables           | Y    | N         | Y    | N  | N   |
+    | Write encrypted tables          | Y    | N         | Y    | N  | N   |
 
 ## Data File Formats
 
 | Format  | Java | PyIceberg | Rust | Go | C++ |
 |---------|------|-----------|------|----|-----|
 | Parquet | Y    | Y         | Y    | Y  | Y   |
 | ORC     | Y    | N         | N    | N  | N   |
-| Puffin  | Y    | N         | N    | N  | N   |
+| Puffin  | Y    | N         | Y    | Y  | Y   |
 | Avro    | Y    | N         | N    | N  | Y   |
 
 ## File IO
 
 | Storage           | Java | PyIceberg | Rust | Go | C++  |
 |-------------------|------|-----------|------|----|------|
 | Local Filesystem  | Y    | Y         | Y    | Y  | Y    |
-| Hadoop Filesystem | Y    | Y         | Y    | Y  | N    |
-| S3 Compatible     | Y    | Y         | Y    | Y  | N    |
+| Hadoop Filesystem | Y    | Y         | N    | N  | N    |
+| S3 Compatible     | Y    | Y         | Y    | Y  | Y    |
 | GCS Compatible    | Y    | Y         | Y    | Y  | N    |
 | ADLS Compatible   | Y    | Y         | Y    | Y  | N    |
 
 ## Table Maintenance Operations
 
-### Table Spec V1
-
-| Operation                   | Java | PyIceberg | Rust | Go | C++ |
-|-----------------------------|------|-----------|------|----|-----|
-| Update schema               | Y    | Y         | Y    | Y  | Y   |
-| Update partition spec       | Y    | Y         | Y    | Y  | Y   |
-| Update table properties     | Y    | Y         | Y    | Y  | Y   |
-| Replace sort order          | Y    | N         | Y    | Y  | Y   |
-| Update table location       | Y    | Y         | Y    | Y  | Y   |
-| Update statistics           | Y    | Y         | Y    | Y  | Y   |
-| Update partition statistics | Y    | N         | N    | N  | N   |
-| Expire snapshots            | Y    | N         | N    | Y  | N   |
-| Manage snapshots            | Y    | N         | N    | Y  | N   |
-
-### Table Spec V2
-
-| Operation                   | Java | PyIceberg | Rust | Go | C++ |
-|-----------------------------|------|-----------|------|----|-----|
-| Update schema               | Y    | Y         | N    | Y  | Y   |
-| Update partition spec       | Y    | Y         | N    | Y  | Y   |
-| Update table properties     | Y    | Y         | Y    | Y  | Y   |
-| Replace sort order          | Y    | N         | Y    | Y  | Y   |
-| Update table location       | Y    | Y         | Y    | Y  | Y   |
-| Update statistics           | Y    | Y         | Y    | Y  | Y   |
-| Update partition statistics | Y    | N         | N    | N  | N   |
-| Expire snapshots            | Y    | N         | N    | Y  | N   |
-| Manage snapshots            | Y    | N         | N    | Y  | N   |
+### Table Spec
+
+=== "V1 - V3"

Review Comment:
   Could we split this into `V1 - V2` / `V3` tabs, or footnote PyIceberg as 
REST-only on V3? As I read 0.12.0, client-side V3 metadata writes raise 
([metadata.py#L587-L588](https://github.com/apache/iceberg-python/blob/75396614a5f093cf24e93c7d916ee2cda0bdf44e/pyiceberg/table/metadata.py#L587-L588)),
 which matches [Write table metadata = 
N](https://github.com/apache/iceberg/blob/4d572b4ee92d4fe10304ca07194dc27a3036dcd6/site/docs/status.md#L108),
 but here update schema, properties and expire snapshots are `Y`. The 
`timestamp_ns` / `unknown` `Y` cells read the same way, since `write_manifest` 
raises on V3 
([manifest.py#L1290-L1302](https://github.com/apache/iceberg-python/blob/75396614a5f093cf24e93c7d916ee2cda0bdf44e/pyiceberg/manifest.py#L1290-L1302)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to