slachiewicz opened a new pull request, #25: URL: https://github.com/apache/iceberg-verification/pull/25
Closes #23. `make validate` now recomputes every `truncate`, `year`, `month`, `day` and `hour` value from its input, as it already did for `bucket`. The year, month and day cases gain `1969-01-01` and `1968-12-31` inputs and the hour cases gain `1969-12-31T23:00:00` and `1969-12-31T22:59:59.999999`, in every date and timestamp form. These are additions; no existing expected value changes. Pre-epoch values round down, as the existing `1969-12-31T23:59:59.999999` → `-1` cases already assume. The spec's "hours from 1970-01-01 00:00:00" does not state a direction for negative values. The validator refuses a truncate case whose result would overflow, which the surface leaves unsettled. Cross-checked: all 185 non-null truncate and temporal values match iceberg-go's transforms (1827440), and the 149 temporal values match PyIceberg's `pyiceberg.utils.datetime` (1ee2f40). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
