tanmayrauth commented on PR #2444:
URL: https://github.com/apache/iceberg-go/pull/2444#issuecomment-6910028739

   Thanks @zeroshade. I opened #2616  for hashing straight from the Arrow 
buffers. On the nits: the two overlapping selected-column tests are now a 
single TestComputeNDVsSelectedColumn, which also covers a column named twice. 
TestComputeNDVsUnknownColumnErrors now asserts ErrInvalidArgument. On whether 
the "can't find column" branch is reachable, Andrei pointed out that "*" 
reaches it; after his review I also moved name checks ahead of the scan, so 
every unknown name now hits that branch (does_not_exist, *, and wrong-case ID 
are all tested), instead of a plain unknown name failing earlier in 
Schema.Select with ErrInvalidSchema. The rest of this push covers Andrei's 
review: geo columns are skipped by default and rejected by name, empty tables 
return no sketches, and the result now includes the snapshot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to