shivadarshan-devadiga opened a new pull request, #18986:
URL: https://github.com/apache/iceberg/pull/18986

   Closes #18950.
   
   [SPARK-58933](https://github.com/apache/spark/pull/58204) fixes expression 
resolution in the target of `INSERT INTO IDENTIFIER(...)`. This adds 
`testInsertIntoComputedIdentifier` to `TestSparkCatalogOperations` in 
`spark/v4.2`: it inserts into `IDENTIFIER(lower('<table>'))` and checks the 
inserted row. The test is the `insertIntoComputedIdentifier` regression from 
the Spark 4.2.1 verification draft #18294 by @manuzhang, kept as a permanent 
test.
   
   It is added to Spark 4.2 only. The bug is in Spark 4.2.0 and fixed in 4.2.1. 
On Spark 4.1.4, the version `spark/v4.1` uses, the same test passes for all 4 
catalogs.
   
   Testing:
   - The new test passes for all 4 catalog configurations of the suite on Spark 
4.2.1, the version on main. The rest of `TestSparkCatalogOperations` passes too.
   - With `spark42` set to 4.2.0, which doesn't have SPARK-58933, all 4 runs 
fail with `UNSUPPORTED_INSERT.RDD_BASED: Can't insert into the target`.
   - Added temporarily to `spark/v4.1` on Spark 4.1.4, it passes for all 4 
catalogs.
   - `spotlessCheck` passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to