rdblue commented on code in PR #18984:
URL: https://github.com/apache/iceberg/pull/18984#discussion_r4580496087
##########
core/src/main/java/org/apache/iceberg/V4Metadata.java:
##########
@@ -601,32 +579,12 @@ public <T> void set(int pos, T value) {
@Override
public <T> T get(int pos, Class<T> javaClass) {
- return javaClass.cast(get(pos));
+ return javaClass.cast(getInternal(pos));
}
- private Object get(int pos) {
Review Comment:
Refactored this into the child classes because leaf and root manifests don't
use the same schema. This method must match the schema or else there are writer
errors.
I think this refactor also made this a bit easier to understand and cleaned
up how partition specs are handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]