akritishakya opened a new pull request, #2598:
URL: https://github.com/apache/iceberg-go/pull/2598

   Closes  #2491 
   ## Problem
   When a concurrent commit adds a deletion vector for a data file that a 
`RowDelta` also adds one for, `validateNoConcurrentReplacedDVs` rejects the 
retry with an error that wraps no sentinel. As a result,
   `errors.Is(err, table.ErrCommitFailed)` is false and the transaction is not 
marked unusable.
   
   ## Changes
   - Wrap the error with `ErrConflictingDeleteFiles`, which wraps 
`ErrCommitFailed`. `Transaction.Commit` then fails with 
`ErrTransactionUnusable`.
   - Extend `TestRowDeltaRejectsConcurrentFirstDVOnRetry` to assert the error 
sentinels and that a second `Commit` on the same transaction fails with 
`ErrTransactionUnusable`.
   
   ## Testing
   `go test ./table/...`. The new assertions fail without the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to