manuzhang opened a new issue, #18953:
URL: https://github.com/apache/iceberg/issues/18953

   ### Feature Request / Improvement
   
   Add Iceberg-backed coverage for 
[SPARK-60403](https://github.com/apache/spark/pull/59653). Ordinary joins and 
MERGE tests do not force the generated class to become large enough for helper 
functions to move into nested classes. #18294 explicitly records this exact 
upstream regression as untested.
   
   The affected helpers belong to full-outer `SortMergeJoinExec`, 
full/build-side-outer `ShuffledHashJoinExec`, and `MergeRowsExec`. Their calls 
must use the qualified names returned by the code-generation context. Otherwise 
compilation can fail and Spark can silently fall back to execution without 
whole-stage code generation.
   
   Acceptance criteria:
   
   - [ ] Build deterministic large generated expressions over Iceberg input 
that force nested-class helper placement, following the upstream regression.
   - [ ] Exercise the relevant outer join operators and a Spark 4.2 Iceberg 
MERGE path using `MergeRowsExec`.
   - [ ] Prove the intended physical operator and nested-class path are reached.
   - [ ] Require generated code to compile with codegen fallback disabled, and 
assert exact result rows or final table contents.
   - [ ] Place tests in the owning Spark integration/extension suites and cover 
supported Spark lines where the operator and fix apply.
   
   This tracks a coverage gap rather than a newly reproduced Iceberg bug. Use 
main's published Spark dependencies; the candidate staging setup from #18294 is 
not needed. Related feature tracker: #17959.
   
   ### Query engine
   
   Spark
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to