huaxingao commented on code in PR #18885:
URL: https://github.com/apache/iceberg/pull/18885#discussion_r4575228519
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -51,6 +51,16 @@
class SchemaUpdate implements UpdateSchema {
private static final Logger LOG =
LoggerFactory.getLogger(SchemaUpdate.class);
private static final int TABLE_ROOT_ID = -1;
+ private static final Set<String> COLUMN_PROPERTY_PREFIXES =
Review Comment:
+1. Spark 4.2 `SparkCatalog` also has its own `COLUMN_PROPERTY_PREFIXES`
copy (used by `CREATE TABLE LIKE`), and it's already missing the compression
codec/level prefixes. A shared set in `TableProperties` would keep them in
sync. Should we switch Spark 4.2 `SparkCatalog` to it too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
