CTTY commented on code in PR #3670:
URL: https://github.com/apache/iceberg-rust/pull/3670#discussion_r4571732504


##########
crates/iceberg/src/io/object_cache.rs:
##########
@@ -127,10 +128,14 @@ impl ObjectCache {
     }
 
     /// Retrieves an Arc [`Manifest`] from the cache
-    /// or retrieves one from FileIO and parses it if not present
-    pub(crate) async fn get_manifest(&self, manifest_file: &ManifestFile) -> 
Result<Arc<Manifest>> {
+    /// or retrieves one from FileIO and parses it on `runtime` if not present
+    pub(crate) async fn get_manifest(
+        &self,
+        manifest_file: &ManifestFile,
+        runtime: &Runtime,

Review Comment:
   Maybe we should just push Runtime down to `ObjectCache`? Right now 
`ObjectCache` and `Runtime` are both under `Table` and `ObjectCache` is 
`pub(crate)` mostly, so I think it would make sense to have `ObjectCache` be 
aware of `Runtime` by default instead of having to ask for it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to